Include exclamation point in month element format to prevent time-of-day related bugs

laminas / laminas-form

Validate and display simple and complex forms, casting forms to business objects and vice versa

https://docs.laminas.dev/laminas-form/

BSD 3-Clause "New" or "Revised" License

80 stars 52 forks source link

Include exclamation point in month element format to prevent time-of-day related bugs #218

Closed samuelgmartins closed 1 year ago

samuelgmartins commented 1 year ago

Update to include exclamation mark in month element format

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

As described in issue #217, the month element when validated with DateStep on the 31st and with a month value of less than 31 days returns false validation.

Added testTestDayTimeReset test case to validate if month element date is reset

Fixes #217

Ocramius commented 1 year ago

I think we should target 3.10.x here, since this is a bugfix

Ocramius commented 1 year ago

Since I'm releasing 3.11.0 anyway, rolling with what we have here :)

No point in delaying it further for semantics