laminas / laminas-form

Validate and display simple and complex forms, casting forms to business objects and vice versa
https://docs.laminas.dev/laminas-form/
BSD 3-Clause "New" or "Revised" License
80 stars 52 forks source link

Allow PHP 8.4 #275

Open fezfez opened 1 month ago

fezfez commented 1 month ago
Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

gsteel commented 1 month ago

I'm reluctant to baseline all the deprecations from laminas-validator. Dealing with them now will make upgrading to v3, when it gets released, a lot easier. Merging this PR will mute all those issues… 🤔

Xerkus commented 1 month ago

php 8.4 CANNOT be declared compatible while it is in alpha.

fezfez commented 1 month ago

php 8.4 CANNOT be declared compatible while it is in alpha.

I've seen that the job has begun https://github.com/orgs/laminas/projects/37 maybe it's unclear inside the laminas maintener community?

fezfez commented 1 month ago

I'm reluctant to baseline all the deprecations from laminas-validator. Dealing with them now will make upgrading to v3, when it gets released, a lot easier. Merging this PR will mute all those issues… 🤔

Maybe you should create a 4.0.x branch with the 3.21.x before merging?

Xerkus commented 1 month ago

PHP 8.4 is in alpha release. It can introduce incompatibilities or even BC breaks. It happened before. Releases with PHP 8.4 added to the range will become incompatible in such occurrence but it is impossible to retroactively change the range for past releases.

fezfez commented 1 month ago

According to https://php.watch/rfcs and https://wiki.php.net/todo/php84

The feature freeze is on 13 august, only two RFCs can be merge for 8.4 and none of them can lead to breaking the package, otherwise I understand that's waiting 10 day before merging is not a big deal 👍

Edit : php.watch same to not be up to date, more rfcs can be merge in 8.4 according to https://wiki.php.net/rfc

Xerkus commented 1 month ago

PRs are desirable to highlight any coming issues as well as patches dealing with future compat.

It's the releasing with 8.4 that is premature. Ideally we would want to wait for rc which is in about a month