laminas / laminas-http

Provides an easy interface for performing Hyper-Text Transfer Protocol (HTTP) requests
https://docs.laminas.dev/laminas-http/
BSD 3-Clause "New" or "Revised" License
36 stars 27 forks source link

Inefficient Header Checking #56

Closed gwharton closed 3 years ago

gwharton commented 3 years ago

Feature Request

Q A
New Feature no
RFC no
BC Break no

Summary

Given HTTP headers can get quite large these days, with CSP etc, sometimes running into the many thousands of characters, can the following functions be optimised instead of looping one character at a time?

https://github.com/laminas/laminas-http/blob/b424a148acb02f2383d6a4b673acd0aef9b4edec/src/Header/HeaderValue.php#L33-L57

https://github.com/laminas/laminas-http/blob/b424a148acb02f2383d6a4b673acd0aef9b4edec/src/Header/HeaderValue.php#L70-L90

laminas-bot commented 3 years ago

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee. If you have a security issue, please follow our security reporting guidelines. If you wish to take on the role of maintainer, please nominate yourself

You can continue using laminas/laminas-http safely. Its successor will be PSR-7 in a later revision of laminas/laminas-mvc.