laminas / laminas-http

Provides an easy interface for performing Hyper-Text Transfer Protocol (HTTP) requests
https://docs.laminas.dev/laminas-http/
BSD 3-Clause "New" or "Revised" License
36 stars 27 forks source link

Remove dynamic properties to remove PHP 8.2 deprecation warnings #75

Closed adambalint-srg closed 1 year ago

adambalint-srg commented 1 year ago

Signed-off-by: Ádám Bálint adam.balint@srg.hu

Q A
Documentation no
Bugfix yes
BC Break yes
New Feature no
RFC no
QA no

In PHP 8.2 dynamic properties will be deprecated. I found two dynamic properties, and as I see these properties aren't used, only set. I know that because of the dynamic declaration these properties will be public, so there is the possibility that someone uses these properties. This is why it can be BC break. Or should I create these public properties in these classes?