Bump up PHP version constraint.

[ADmad]

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

Description

[ADmad]

Travis is AWOL.

[weierophinney]

Travis is AWOL.

We're aware; we've used up our allotment of credit hours for the month. I've got a support request in; in the meantime, we'll be attempting to verify manually before merge.

[ADmad]

You'll have to switch to Github Actions (or another CI provider) eventually :slightly_smiling_face:.

[weierophinney]

You'll have to switch to Github Actions (or another CI provider) eventually .

Already planned: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2020-11-02-TSC-Minutes.md#github-actions

[ADmad]

If you want I can add a simple new workflow to run the testsuite on Github Action. You can later remove it or improve upon.

[weierophinney]

If you want I can add a simple new workflow to run the testsuite on Github Action. You can later remove it or improve upon.

Would rather wait, as it will be easier to script adding the workflow(s) to repositories later if they don't already have ad-hoc changes.

[ADmad]

Would rather wait, as it will be easier to script adding the workflow(s) to repositories later if they don't already have ad-hoc changes.

Sorry, I added one. After seeing the test suite passing on PHP 8, I removed it again :slightly_smiling_face:.

[ADmad]

I'll go ahead and make them and push them back after testing on each of the target versions locally.

Cool, I'll await your updates.

[weierophinney]

I took the liberty of removing Prophecy mocks for native PHPUnit mocks... which required a fair bit of change to the SapiStreamEmitterTest, as it had a rather convoluted setup. I extracted much of it to a MockStreamHelper that provides state and callbacks that a mock stream instance can use, which leads to more explicit setup. All the original test cases continue to pass on both lowest and latest dependencies locally, so I'm going to go ahead and merge.