search

laminas / laminas-hydrator

Serialize objects to arrays, and vice versa
https://docs.laminas.dev/laminas-hydrator/
BSD 3-Clause "New" or "Revised" License
123 stars 32 forks source link

Add PHP 8.4 compatibility #124

Open Slamdunk opened 3 months ago

Xerkus commented 3 months ago

PHP 8.1 support won't end for one more year

Slamdunk commented 3 months ago

I didn't know Laminas has a committment towards all PHP versions with security support, fixed it.

BTW, I've opened this PR cause I have time for this right now: I'll fix everything only once PHP 8.4 is out.

Xerkus commented 3 months ago

We won't be adding PHP 8.4 to the versions just yet but we can merge patches for future compat. To make CI run you can add php 8.4 to platform ignores. Check .laminas-ci.json history

Slamdunk commented 3 months ago

Don't know if I did everything you asked me, can you check it please?

Xerkus commented 3 months ago

Sorry if I got you confused. We do want 8.4 added to composer in the PR. We won't be merging it until php reached stable enough milestone https://wiki.php.net/todo/php84

temporary override for the platform ignore is needed in .laminas-ci.json to make CI run checks with 8.4 as it otherwise currently fails at composer install step.

Changes here do not appear significant enough to do a separate release. They can wait with the PR.