laminas / laminas-i18n-resources

Provides validator and captcha translations for laminas-i18n's Translator
https://docs.laminas.dev/laminas-i18n-resources/
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

PHP 8 support #16

Closed tobias-trozowski closed 3 years ago

tobias-trozowski commented 3 years ago
Q A
New Feature yes

Description

Updating to add PHP 8.0 support for #14

In order to make this repository compatible, one has to follow these steps:

Closes #14

froschdesign commented 3 years ago

@tobias-trozowski I'm sorry for the late response.

The XML configuration file for PHPUnit also needs an update:

<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
         bootstrap="vendor/autoload.php"
         colors="true">
    <testsuites>
        <testsuite name="laminas-i18n-resources Test Suite">
            <directory>./test</directory>
        </testsuite>
    </testsuites>
    <coverage>
        <include>
            <directory suffix=".php">./src</directory>
        </include>
    </coverage>
</phpunit>

Reference: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-coverage-element

Thanks in advance!

tobias-trozowski commented 3 years ago

@froschdesign all done

froschdesign commented 3 years ago

@tobias-trozowski Could you rebase against the branch 2.7.x? This will use the new CI workflow. Thanks in advance! 👍

froschdesign commented 3 years ago

Fixed with #18