search

laminas / laminas-i18n-resources

Provides validator and captcha translations for laminas-i18n's Translator
https://docs.laminas.dev/laminas-i18n-resources/
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

Translations for portuguese from Portugal (pt_PT) #3

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

Captcha and Validate translations for portuguese from Portugal (pt_PT).

Originally posted by @rolandoisidoro at https://github.com/zendframework/zend-i18n-resources/pull/38

weierophinney commented 4 years ago

We need another Portuguese speaking person to reviewing it. (Two-man rule)

Originally posted by @froschdesign at https://github.com/zendframework/zend-i18n-resources/pull/38#issuecomment-401254100

weierophinney commented 4 years ago

Hi @froschdesign, I'm also Portuguese and I reviewed @rolandoisidoro translation. It seems good to merge to me!

Originally posted by @falsovsky at https://github.com/zendframework/zend-i18n-resources/pull/38#issuecomment-401295195

weierophinney commented 4 years ago

Sorry for the late reply.

There seem to be an issue with wrong translation keys used across all languages. This work probably have some of them too since you most likely used english provider as a source. A work to get all the keys validated is quite time consuming which I lack at the moment. As such I cannot proceed with merging and releasing this PR.

If someone can undertake the work to validate the keys in english provider and then implement tests to ensure there is no key mismatch between different languages, I will gladly review the work and make sure it is accepted promptly. At which point I will be able to accept this PR as well.

Originally posted by @Xerkus at https://github.com/zendframework/zend-i18n-resources/pull/38#issuecomment-505238684