search

laminas / laminas-i18n-resources

Provides validator and captcha translations for laminas-i18n's Translator
https://docs.laminas.dev/laminas-i18n-resources/
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

Update translations #8

Open mpesari opened 4 years ago

mpesari commented 4 years ago
Q A
Documentation no
Bugfix yes
BC Break maybe
New Feature no
RFC no
QA no

Description

This PR

froschdesign commented 4 years ago

@mpesari Thank you for your time and this contribution!

Some points that come to my mind:

  1. The support for the PSR-7 UploadedFileInterface was added with version 2.11.0 of the validator component. Therefore we must ensure that older versions of laminas-validator get the correct translations. This can be done with the conflict section of Composer.
  2. With the change of the English messages we also have to modify all translations. (I can translate the messages for German. For all other languages with need help – separate pull requests.)
  3. We need an unit test to check all message identifiers. See: #2
froschdesign commented 4 years ago

Btw. we need another Finnish speaking person to reviewing it. (Two-man rule)