Closed renovate[bot] closed 2 years ago
renovate[bot]
commented
2 years ago This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
Ocramius
commented
2 years ago /cc @gsteel all updates mentioned here are related to your recent work: do you know whether the casing of those locales changed? 🤔
gsteel
commented
2 years ago I observed this test failure locally a few days ago. It's an odd one that I haven't tracked down yet - the $encoding variable is explicitly lowercased in AbstractUnicode so I'm unsure why this test ever passed in the first place.
Before the change this test was iterating over a raw object, and now it's got an iterable.
I'm tempted to say that the test is wrong here rather than an regression in laminas-filter.
I'll try and look into it properly later on.
gsteel
commented
2 years ago I'm still none the wiser as to why the currently failing test hasn't always failed.
See https://github.com/laminas/laminas-filter/pull/66 - laminas-filter has been lowercasing the encoding option since 2012
Commit 5b81532 updates the failing test to expect a lowercase value
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 2am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
â™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Read more information about the use of Renovate Bot within Laminas.