laminas / laminas-inputfilter

Normalize and validate input sets from the web, APIs, the CLI, and more, including files
https://docs.laminas.dev/laminas-inputfilter/
BSD 3-Clause "New" or "Revised" License
42 stars 29 forks source link

Removes deprecation messages which lead to irritation because there are no alternative paths for implementation #77

Closed froschdesign closed 2 years ago

froschdesign commented 2 years ago

The current deprecations of methods and properties cannot be resolved or bypassed by other options or workarounds. The isValid method of the Input class uses and needs these deprecated methods and properties:

https://github.com/laminas/laminas-inputfilter/blob/2e9a2f2b867eb423338a9948ae0027ec4e556378/src/Input.php#L370-L405

https://github.com/laminas/laminas-inputfilter/blob/2e9a2f2b867eb423338a9948ae0027ec4e556378/src/Input.php#L20-L32

https://github.com/laminas/laminas-inputfilter/blob/2e9a2f2b867eb423338a9948ae0027ec4e556378/src/Input.php#L46-L51

An alternative solution or way was never provided and in its current state, it would not work. Therefore the deprecation was too early and all discussions and developments in this direction have never been completed or are very old.

See:

As long as we do not have an alternative solution, the current deprecation messages are confusing.

Ocramius commented 2 years ago

Ok, let's just re-generate the baseline, and then this can be merged.

Can't do myself: don't have docker on this PC today :D

Ocramius commented 2 years ago

Merging as-is here: can't re-generate baseline ATM, but it's a minor issue.

Ocramius commented 2 years ago

Thanks @froschdesign!