Remove impossible check for Logger === null

laminas / laminas-log

Robust, composite logger with filtering, formatting, and PSR-3 support

https://docs.laminas.dev/laminas-log/

BSD 3-Clause "New" or "Revised" License

26 stars 30 forks source link

Remove impossible check for Logger === null #9

Closed TysonAndre closed 3 years ago

TysonAndre commented 4 years ago

The parameter type signature ensures it is never null. Update the @throws documentation, it's a TypeError.

Q	A
Documentation	yes?
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	no

Description

Dead code elimination for issue detected by static analysis. Not 100% sure if master or develop is the most appropriate.

boesing commented 3 years ago

@TysonAndre Thanks for this PR. I've rebased against latest 2.13.x branch. If fix the DCO check by applying the suggested changes from here, I'll merge this and create the next release afterwards.

boesing commented 3 years ago

Thanks, @TysonAndre!