search

laminas / laminas-mime

Create and parse MIME messages and parts
https://docs.laminas.dev/laminas-mime/
BSD 3-Clause "New" or "Revised" License
29 stars 23 forks source link

Add basic suppoort for php 8.3 #35

Closed xvilo closed 10 months ago

xvilo commented 10 months ago

Add basic support for PHP 8.3, when running the test suite locally all tests are passing

xvilo commented 10 months ago

I see there are some unrelated linting steps failing, does the project expect me to fix them or can we leave them as is?

gsteel commented 10 months ago

@xvilo It would be great if you could get CI green here. There are a bunch of trailing spaces in the README and some extra blank lines - If you could trim those as per the error messages here: https://github.com/laminas/laminas-mime/actions/runs/6731571212/job/18296531885?pr=35#step:3:218

… it would be very much appreciated, and it would fix CI for both Docs and README linting jobs.

xvilo commented 10 months ago

@gsteel It seems the README linting issues are resolved with my latest commit. However, the Autocloser / autoclose job is still failing because of a missing token. I expect this to not be an issue, but I have no clear idea on what it does.

Please do let me know this also needs to be addressed, otherwise I hope this can be merged 🎉

xvilo commented 10 months ago

Thanks, @Ocramius, that was fast ❤️