laminas / laminas-modulemanager

Modular application system for laminas-mvc applications

https://docs.laminas.dev/laminas-modulemanager/

BSD 3-Clause "New" or "Revised" License

30 stars 18 forks source link

feat: Add Psalm integration #28

Closed alexraputa closed 2 years ago

alexraputa commented 2 years ago

Closes #19

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	yes

arueckauer commented 2 years ago

@Ocramius This has been sitting around for a while. Does it need a review or can it be merged?

AwaitingMaintainerResponse

Ocramius commented 2 years ago

@arueckauer working on getting this merged, thanks! :+1:

Ocramius commented 2 years ago

Aaah, nope, we can't merge this: it is full of BC breaks due to missing final in our classes :(

Ocramius commented 2 years ago

I have a few minutes, will try adjusting myself :)

Ocramius commented 2 years ago

@alexraputa whoops, I rolled over your changes, sorry :S

Ocramius commented 2 years ago

:ship: thanks @alexraputa! Sorry for the noise and delay!

alexraputa commented 2 years ago

@Ocramius no problem 😉