search

laminas / laminas-modulemanager

Modular application system for laminas-mvc applications
https://docs.laminas.dev/laminas-modulemanager/
BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

fix - loadModule reinitializes modules if the module has already been… #34

Open nusphere opened 2 years ago

nusphere commented 2 years ago
Q A
Bugfix yes

Description

As descripted in #32 . there is an bug when loading a module with another loading name. there are currently 3 ways to load the same module via the module manager. the following options are available:

if you use method 1 (namespace) and method 2 (class string) for the same module in an application, it will be loaded twice and reset the previous settings.

this pull request fixes the false behavior and prevents a module from being loaded twice.

fixes #32

nusphere commented 2 years ago

any review possible?

froschdesign commented 2 years ago

@Xerkus Can you look at this? Is the module manager still relevant at all? Thanks in advance! 👍

steffendietz commented 1 year ago

Hi. Is there anything holding this fix back?

The target branch of this MR probably needs to be adjusted, given that 2 minor releases were published since this MR was opened.

nusphere commented 1 year ago

@froschdesign - ping