search

laminas / laminas-mvc-form

Metapackage with all requirements needed to use laminas-form with laminas-mvc.
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Updated dependencies, removed PHP constraint and conflict #6

Closed driehle closed 3 years ago

driehle commented 3 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Closes #5

driehle commented 3 years ago

@froschdesign Would you mind having a look at this?

Fahl-Design commented 3 years ago

Hi, looks like there are some more updates that needs to be addressed: 

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laminas/laminas-mvc-form[1.0.0, 1.0.x-dev] require php ^5.6 || ^7.0 -> your php version (8.0.9) does not satisfy that requirement.
    - laminas/laminas-mvc-form[1.1.0, 1.1.x-dev, 1.2.x-dev] require laminas/laminas-code ^3.5.0 -> found laminas/laminas-code[dev-develop, 3.5.0, 3.5.1, 3.5.x-dev (alias of dev-develop)] but it conflicts with your root composer.json require (^4.4.2).
    - Root composer.json requires laminas/laminas-mvc-form ^1.0 -> satisfiable by laminas/laminas-mvc-form[1.0.0, 1.0.x-dev, 1.1.0, 1.1.x-dev, 1.2.x-dev].

laminas-code is now at version 4.4.2

driehle commented 3 years ago

@Fahl-Design Well, with its v3 release, laminas-form switched its dependeny from laminas/laminas-code to doctrine/annotations, see https://docs.laminas.dev/laminas-form/v3/migration/v2-to-v3/#new-dependencies. The underlying reason is that laminas-code dropped its annotation parsing engine with their v4 release, so there is no way to update to laminas-code v4!

This is why from my point of view we must make two things with laminas-mvc-form (this metapackage here):

@froschdesign @geerteltink @michalbundyra Would be great if one of you could have a look at this.

driehle commented 3 years ago

@froschdesign Is there still anything holding this back from being merged and released into 1.2.0?

froschdesign commented 3 years ago

@driehle Thank you for your time and this contribution! 👍

(And thanks for the reminder!)

driehle commented 3 years ago

@froschdesign No worries and thanks for tagging a new release :-)