search

laminas / laminas-mvc-form

Metapackage with all requirements needed to use laminas-form with laminas-mvc.
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

updated to laminas-form v3 #7

Closed driehle closed 2 years ago

driehle commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break yes
New Feature yes
RFC no
QA no

Description

This PR updates laminas-form from v2 to v3. To keep the functionality of this package, doctrine/annotations has been added to the dependencies, while laminas-code has been removed. This allows annotation parsing with laminas-form v3, as laminas-code did with v2.

From my point of view this should be considered a BC break, as laminas-form v3 introduced typed parameters and return values. Furthermore, the switch from laminas-code to doctrine/annotations may - at least at some lower level, i.e. when users add custom annotations - bring some BC breaks as well.

Therefore, this should go in a 2.0.x, though that branch does not exist yet, hence the target of 1.3.x currently.

driehle commented 2 years ago

@froschdesign This the follow-up as discussed here: https://github.com/laminas/laminas-mvc-form/pull/6#discussion_r658754975

froschdesign commented 2 years ago

I am waiting for the workflow to start, but there is no code to check! 😄

froschdesign commented 2 years ago

@driehle Thank you again for your time and your help! 👍