search

laminas / laminas-mvc-plugin-flashmessenger

Plugin for creating and exposing flash messages via laminas-mvc controllers
https://docs.laminas.dev/laminas-mvc-plugin-flashmessenger/
BSD 3-Clause "New" or "Revised" License
10 stars 16 forks source link

feat(docs): fixed template of rendering success flash messages #37

Closed devlubinets closed 7 months ago

devlubinets commented 10 months ago

Docs section "Basic usage" from 1.10.x has mistake in part "Render a Flash Message", because we can't render success message by <?= $this->flashMessenger()->render() ?>

https://docs.laminas.dev/laminas-mvc-plugin-flashmessenger/basic-usage/ image

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

devlubinets commented 10 months ago

I don't know how can I fix Continuous Integration / ci / QA Checks (README Linting) Could you help me?

Ocramius commented 10 months ago

@devlubinets don't worry about it: not related to your changes :-)

Ocramius commented 10 months ago

@froschdesign I dropped the milestone here: your decision whether this needs to be merged as bugfix in an older release

froschdesign commented 7 months ago

Fixed with #39 and released with version 1.10.1.

@devlubinets Thanks for reporting the problem! 👍🏻