search

laminas / laminas-mvc-skeleton

Skeleton application for creating laminas-mvc based projects.
https://docs.laminas.dev/mvc/
BSD 3-Clause "New" or "Revised" License
172 stars 66 forks source link

Fixes HTML and CSS for navbar and toggler #76

Closed tyrsson closed 11 months ago

tyrsson commented 1 year ago
Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Tell us about why this change is necessary: Changes address the Toggler issues in the skeleton layout and a style issue in the Laminas Navigation menu helper tutorial.

Review of changes.

  1. Removed an unnecessary div class="navbar-header" since bootstrap 5.2.3 does not support this class and the skeleton apps style.css does not target it either.
  2. Added a span wrapping the MVC Skeleton text with classes navbar-text text-light to improve the spacing of the text next to the logo.
  3. Changed the order of the markup so as to move the toggler to the right side and changed the collapse breakpoint to sm from md. The breakpoint is still triggered by simply shrinking the browser window.
  4. Added the needed style in style.css to allow the Laminas Navigation tutorial to work as stated in the docs. It targets specifically the .navbar li.active a so as to not style any other navigation items created by the navigation component. Seemed the least intrusive way to handle it.

Please reference the following: Toggler: https://getbootstrap.com/docs/5.2/components/navbar/#toggler

For the MVC Skeleton text: https://getbootstrap.com/docs/5.2/components/navbar/#text-1

Xerkus commented 11 months ago

Thanks @Tyrsson