search

laminas / laminas-mvc-skeleton

Skeleton application for creating laminas-mvc based projects.
https://docs.laminas.dev/mvc/
BSD 3-Clause "New" or "Revised" License
172 stars 66 forks source link

Update Bootstrap to v5.3 #84

Open visto9259 opened 8 months ago

visto9259 commented 8 months ago

Feature Request

Q A
New Feature no
RFC no
BC Break no

Summary

The version of Bootstrap that is bundled in the skeleton is version 5.2. Bootstrap has been on 5.3 for a year now.

The skeleton should use the bundled Bootstrap JS to have all the tools.

It may be preferable to use the CDN?

visto9259 commented 8 months ago

If you agree to use the bundled Bootstrap js file, I have the pull request ready to submit

gsteel commented 8 months ago

Send in the patch @visto9259 👍

juizmill commented 4 months ago

I think there should be a package manager like webpack, vite etc.

Making it much easier and more modern when using CSS and JS packages.

gsteel commented 4 months ago

I think there should be a package manager like webpack, vite etc.

Making it much easier and more modern when using CSS and JS packages.

Not really. Everyone does front-end differently. It is not appropriate for a PHP project skeleton to dictate which front-end tech to use.

It's enough to provide pre-compiled Bootstrap so that it can easily be ripped out and replaced with whatever the user wants.

juizmill commented 4 months ago

I think there should be a package manager like webpack, vite etc. Making it much easier and more modern when using CSS and JS packages.

Not really. Everyone does front-end differently. It is not appropriate for a PHP project skeleton to dictate which front-end tech to use.

It's enough to provide pre-compiled Bootstrap so that it can easily be ripped out and replaced with whatever the user wants.

My suggestion is to create a skeleton for the front-end base with modern tools. Currently Bootstrap is set to "default"

visto9259 commented 4 months ago

@juizmill I understand your need to have a "starter kit" that provides a framework for front end work. Unfortunately, it will not come from this project. This skeleton's purpose is to provide a quick starting point for the development of a PHP server using the Laminas MVC and component framework. The skeleton does not "endorse" Bootstrap as the front end CSS and JS to use in applications. Bootstrap is just an example to get users started quickly.

I personally use Bootstrap and React in my app based on Laminas MVC. I use Grunt, Webpack and other tools in the dev/build workflows.

Take a look at this guide https://visto9259.github.io/docs/laminas-webpack-guide-getting-started

I will not pretend that it is the best workflow as it is outdated and could be improved but it will give you a starting point for what you are looking for.

thalles commented 4 months ago

I think CDN is a good way