search

laminas / laminas-mvc

Laminas's event-driven MVC layer, including MVC Applications, Controllers, and Plugins
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
144 stars 53 forks source link

Minor comment update #12

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

The statement in injectEventManager's comments that a shared event manager is injected into an existing event manager is incorrect - the code replaces the existing event manager with a new one. That's what I updated.

I may have added too much 'how it works' detail, but I puzzled over this a bit so I thought the explanation might help future readers.

Originally posted by @bitwombat at https://github.com/zendframework/zend-mvc/pull/285

weierophinney commented 4 years ago

Also, I wonder about the pre-existing comment that "the conditional will always pass". I think that's true. Then does it need to be a conditional?

Originally posted by @bitwombat at https://github.com/zendframework/zend-mvc/pull/285#issuecomment-397136114