search

laminas / laminas-mvc

Laminas's event-driven MVC layer, including MVC Applications, Controllers, and Plugins
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
142 stars 51 forks source link

Apply PHP 8.0 Syntax and constructor promotion #140

Closed samsonasik closed 1 year ago

samsonasik commented 1 year ago

Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com

Q A
QA yes

Description

Since composer.json require php 8.0, php 8.0 syntax can constuctor promotion can be applied.

samsonasik commented 1 year ago

All green 🎉

Ocramius commented 1 year ago

Thanks @samsonasik!

TomasVotruba commented 1 year ago

Amazing work :partying_face:

Ocramius commented 1 year ago

@TomasVotruba we still need to automate @samsonasik away xD

TomasVotruba commented 1 year ago

@Ocramius We're working on that together... :wink: You'll notice our Github accounts start to look like human speaking :laughing:

Ocramius commented 1 year ago

@TomasVotruba aware, just saying that we probably need to put some effort in making this some sort of CI / bot.

Absolutely hats off to @samsonasik's thankless and constant efforts, but I think that would be a big win for the ecosystem at large :+1:

TomasVotruba commented 1 year ago

@Ocramius We already use it in CI as automated contributor: https://github.com/rectorphp/rector-src/blob/main/.github/workflows/rector.yaml Just change the rector.php setup and everything else happens by itself :)

Ocramius commented 1 year ago

Yeh, I discussed it with @samsonasik before: what we need is something that suggests changes (with github actions output format), rather than something that applies the changes :)

I haven't worked on it myself yet, but probably something for https://github.com/rectorphp/rector/tree/b9c04e2a17bf233037d76ea2b9b2d7b411b5ec41/src/Console/Formatter

Someday I'll try helping out there :D