Closed github-actions[bot] closed 1 year ago
Requesting a review by others: my eyes are swirling after this last merge.
And yes, --prefer-lowest
has some failures, to be investigated/fixed before merge
static closure
in lowest phpunit seems cause it:
There were 2 errors:
1) LaminasTest\Mvc\Service\ViewFeedStrategyFactoryTest::testReturnsFeedStrategy
Cannot bind an instance to a static closure
/github/workspace/src/Service/ViewFeedStrategyFactory.php:27
/github/workspace/test/Service/ViewFeedStrategyFactoryTest.php:29
2) LaminasTest\Mvc\Service\ViewManagerFactoryTest::testReturnsHttpViewManager
Cannot bind an instance to a static closure
@Ocramius I can push to remove static
if you want for both methods above.
@samsonasik feel free to push to this branch :+1:
All green 🎉
Oooh, we still have prophecy here...
We should drop it in 3.6.x
and merge-up, at some point.
@samsonasik green OK, but still need a careful review :)
Release Notes for 3.5.0
3.5.0
Enhancement