laminas / laminas-mvc

Laminas's event-driven MVC layer, including MVC Applications, Controllers, and Plugins
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
142 stars 51 forks source link

Merge release 3.5.0 into 4.0.x #141

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Release Notes for 3.5.0

3.5.0

Enhancement

Ocramius commented 1 year ago

Requesting a review by others: my eyes are swirling after this last merge.

And yes, --prefer-lowest has some failures, to be investigated/fixed before merge

samsonasik commented 1 year ago

static closure in lowest phpunit seems cause it:

There were 2 errors:

1) LaminasTest\Mvc\Service\ViewFeedStrategyFactoryTest::testReturnsFeedStrategy
Cannot bind an instance to a static closure

/github/workspace/src/Service/ViewFeedStrategyFactory.php:27
/github/workspace/test/Service/ViewFeedStrategyFactoryTest.php:29

2) LaminasTest\Mvc\Service\ViewManagerFactoryTest::testReturnsHttpViewManager
Cannot bind an instance to a static closure

@Ocramius I can push to remove static if you want for both methods above.

Ocramius commented 1 year ago

@samsonasik feel free to push to this branch :+1:

samsonasik commented 1 year ago

@Ocramius done https://github.com/laminas/laminas-mvc/pull/141/commits/8b92ee5d7a72dc08957dbd7c75a92301fe0f3139

samsonasik commented 1 year ago

All green 🎉

Ocramius commented 1 year ago

Oooh, we still have prophecy here...

We should drop it in 3.6.x and merge-up, at some point.

Ocramius commented 1 year ago

@samsonasik green OK, but still need a careful review :)