search

laminas / laminas-mvc

Laminas's event-driven MVC layer, including MVC Applications, Controllers, and Plugins
https://docs.laminas.dev/laminas-mvc/
BSD 3-Clause "New" or "Revised" License
142 stars 51 forks source link

Fix PHP 8.2 deprecations in tests #150

Closed Xerkus closed 1 year ago

Xerkus commented 1 year ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Remove Middleware tests and their dev/optional dependencies since dependencies are not installable on PHP 8 unless platform is ignored and this package no longer supports any of PHP 7 versions. This allows to drop platform ignore used for CI.

Declare properties in tests that were declared dynamically to fix PHP 8.2 deprecations.

Xerkus commented 1 year ago

PHPUnit\Framework\Error\Deprecated: Use of "static" in callables is deprecated this is caused by webmozart/assert transient dependency, it was fixed in 1.11

Not sure if it should be added to dev dependencies to avoid the issue and satisfy CI