laminas / laminas-navigation

Manage trees of pointers to web pages in order to build navigation systems
https://docs.laminas.dev/laminas-navigation/
BSD 3-Clause "New" or "Revised" License
17 stars 11 forks source link

Remove support for PHP 8.0, Add support for PHP 8.3 #51

Closed glo71317 closed 10 months ago

glo71317 commented 11 months ago
Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

glo71317 commented 10 months ago

@Ocramius along with this PR, Following PRs are ready for merge.

https://github.com/laminas/laminas-file/pull/15
https://github.com/laminas/laminas-mvc/pull/159
https://github.com/laminas/laminas-oauth/pull/21
https://github.com/laminas/laminas-server/pull/72
https://github.com/laminas/laminas-mvc-plugin-flashmessenger/pull/36

Few below prs having some dependencies issue

https://github.com/laminas/laminas-db/pull/293
https://github.com/laminas/laminas-cache-storage-deprecated-factory/pull/5

If you don't mind can you please take a look above PRs on priorities so that we can unblock to update dependencies in Magento side.

Ocramius commented 10 months ago

These two need a check by @laminas/technical-steering-committee, since the entire PHPCS changeset got suppressed:

laminas/laminas-db will probably happen sometime in 2024 due to MS SQL Server support simply not being there: https://github.com/laminas/laminas-db/pull/293#issuecomment-1781196353 If we don't test it, we don't support it, and dropping support is a major BC break.

glo71317 commented 10 months ago

@Ocramius Thank you so much for quick response! https://github.com/laminas/laminas-file/pull/15 https://github.com/laminas/laminas-oauth/pull/21 for above both the pr changes, we have entire PHPCS changeset got suppressed as of now because if we go for fixes then lot of file changes will be there if you are agree then we can contribute for the same.

laminas/laminas-db will probably happen sometime in 2024 - It will too late for us, Please discuss internally and let us know about all above three pr changes. there is any way to get it done as soon as possible.

We are ready to instant help regarding the same. Thanks

Ocramius commented 10 months ago

laminas/laminas-db will probably happen sometime in 2024 - It will too late for us, Please discuss internally and let us know about all above three pr changes. there is any way to get it done as soon as possible.

You can certainly get in contact with Microsoft about their SQL Server support: that would help speed things up.

We depend on it, and won't release without testing that first: I can imagine they'd need time to do a release themselves too.

I would also take a moment to remind that you (personally and Adobe Commerce) are a user of a freely provided "as is" library: we do what we can, when we can, and also when we feel like it. If Adobe wants to get guaranteed release schedules on their own terms, I'd expect them to get in direct contact with the TSC and Linux foundation to have some of our work sponsored properly.

gsteel commented 10 months ago

@Ocramius - merging this patch because it looks like discussion relates to other libs