laminas / laminas-oauth

BSD 3-Clause "New" or "Revised" License
8 stars 12 forks source link

Fix collisions between $config property of OAuth client and HTTP client #11

Closed weierophinney closed 3 years ago

weierophinney commented 3 years ago

2.1.0 made changes to internal protected members, refactoring those that were prefixed with an underscore to remove the underscore. Unfortunately, one of these, Laminas\OAuth\Client::$config, is also defined in the parent Laminas\Http\Client, and the two were of different types, leading to type errors (see laminas/laminas-twitter#6).

I've audited to determine what collisions exist, and this was the only one found. As such, I've renamed the property, as well as all references to it internally, to avoid the collision.