search

laminas / laminas-oauth

BSD 3-Clause "New" or "Revised" License
8 stars 12 forks source link

Add PHP 8.1 compatibility #17

Closed karyna-t closed 2 years ago

karyna-t commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC yes/no
QA yes

Description

Add PHP 8.1 support to the composer.json and update require section with the new dependency versions which support 8.1.

Update several methods with strict typing to make sure that they will be used in the same manner as new RFC requires: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

Fixing the test which is failing with php 8.1 installed. (Error was PHP Deprecated: rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in laminas-oauth/src/Http/Utility.php on line 194)

xmav commented 2 years ago

@Ocramius Is there anything else to fix before merge ?

Ocramius commented 2 years ago

@xmav yes: the composer.lock got updated with the wrong system dependencies, and needs to be re-generated.

In order to merge, all CI checks must pass here.

Ocramius commented 2 years ago

Released: https://github.com/laminas/laminas-oauth/releases/tag/2.3.0