search

laminas / laminas-server

Create Reflection-based RPC servers
https://docs.laminas.dev/laminas-server/
BSD 3-Clause "New" or "Revised" License
25 stars 14 forks source link

Update to laminas-coding-standard 2.0 #7

Closed arueckauer closed 4 years ago

arueckauer commented 4 years ago
Q A
Documentation yes
BC Break yes
QA yes

Description

This PR updates laminas-coding-standard to version 2.0 and provides necessary code changes.

Incompatible parts are being ignored now and need to be revisited in a later change. Most, if not all, incompatibilities are because DocBlocks instead of type declarations are used for reflection.

weierophinney commented 4 years ago

@arueckauer I've merged the changes from #8 to the dev-3.0 branch; please rebase and push again. You should be able to also remove the deprecated items on this commit! :tada:

arueckauer commented 4 years ago

@weierophinney Rebase is done and changes are provided. Ready for your review. Only pendent point is the laminas-cli command, which needs clarification (could be provided outside of this PR). Thank you.

arueckauer commented 4 years ago

@weierophinney Thanks for the feedback. I provided the requested changes.

There are three discussions left, all addressing the same CS issue caused by the component's usage of DocBlocks. As mentioned, I would like to investigate an improved solution by using type declarations and dropping support for DocBlocks altogether. This can be addressed after completion of the component maintenance: adding static analysis, bump to PHP 7.4 (or at least 7.3), add typed properties and introduce callables and Iterators. All these I would like to address in separate PRs.

arueckauer commented 4 years ago

@weierophinney You offered me becoming a maintainer, but we did not follow. For now I am happy, if you would merge it. Thank you.

weierophinney commented 4 years ago

Merged - I'll get you setup as a maintainer shortly!