search

laminas / laminas-servicemanager

Factory-Driven Dependency Injection Container
https://docs.laminas.dev/laminas-servicemanager/
BSD 3-Clause "New" or "Revised" License
154 stars 57 forks source link

Allow varexporter v0.5 #237

Closed snapshotpl closed 5 months ago

snapshotpl commented 6 months ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Support for brick/varexporter v0.5.0 to turn supports nikic/PHP-Parser v5 and enabling upgrades to PHPUnit 11 in downstream projects.

snapshotpl commented 6 months ago

Yeah, probably same like here :-( https://github.com/laminas/laminas-config-aggregator/pull/45

kersysgediminas commented 5 months ago

@Ocramius

With latest dependencies, this still installed 0.4.x

- Downloading brick/varexporter (0.4.0)

This is because brick/varexporter (0.5.0) requires nikic/php-parser (5.0.0), but vimeo/psalm only supports nikic/php-parser (4.0.0). However vimeo/psalm is only used in require-dev, therefore brick/varexporter (0.5.0) wouldn't be blocked when installing laminas/laminas-servicemanager as a required dependency

Xerkus commented 5 months ago

Wait, why service manager needs var exporter?

snapshotpl commented 5 months ago

https://github.com/laminas/laminas-servicemanager/blob/ae01570ecdf4559aef2f15d4e79e8c36874f7416/src/Tool/FactoryCreator.php#L171

mrVrAlex commented 5 months ago

So signature VarExporter::export backward compatibility between v0.4 & v0.5 I believe we can safe merge this PR without any consequences...

Ocramius commented 5 months ago

Thanks @snapshotpl @mrVrAlex @kersysgediminas