Closed renovate[bot] closed 2 years ago
This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
@samsonasik would you be up for a PHP 7.4 cleanup patch for this repo?
It should bring us some minimal performance improvements, but those propagate basically everywhere...
@Ocramius I will try
@Ocramius phpcs seems error even on php 7.4, ref https://github.com/laminas/laminas-stdlib/runs/7962260880?check_suite_focus=true
Running ./vendor/bin/phpcs -q --report=checkstyle | cs2pr
PHP Fatal error: Uncaught TypeError: Argument 5 passed to SlevomatCodingStandard\Helpers\Annotation\AssertAnnotation::__construct() must be an instance of PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagValueNode or null, instance of PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagPropertyValueNode given, called in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationHelper.php on line 357 and defined in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/Annotation/AssertAnnotation.php:21
Stack trace:
#0 /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationHelper.php(357): SlevomatCodingStandard\Helpers\Annotation\AssertAnnotation->__construct('@psalm-assert', 2044, 2046, '!null $this->qu...', Object(PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagPropertyValueNode))
#1 /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/SniffLocalCache.php(42): SlevomatCodingStandard\Helpers\AnnotationHelper::SlevomatCodingStanda in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/Annotation/AssertAnnotation.php on line 21
Error: Start tag expected, '<' not found on line 2, column 1
Fatal error: Uncaught TypeError: Argument 5 passed to SlevomatCodingStandard\Helpers\Annotation\AssertAnnotation::__construct() must be an instance of PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagValueNode or null, instance of PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagPropertyValueNode given, called in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationHelper.php on line 357 and defined in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/Annotation/AssertAnnotation.php:21
Stack trace:
#0 /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationHelper.php(357): SlevomatCodingStandard\Helpers\Annotation\AssertAnnotation->__construct('@psalm-assert', 2044, 2046, '!null $this->qu...', Object(PHPStan\PhpDocParser\Ast\PhpDoc\AssertTagPropertyValueNode))
#1 /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/SniffLocalCache.php(42): SlevomatCodingStandard\Helpers\AnnotationHelper::SlevomatCodingStanda in /github/workspace/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/Annotation/AssertAnnotation.php on line 21
<?xml version="1.0" encoding="UTF-8"?>
Yeah, update to an older phpstan/php-doc-parser
for now 👍
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 2am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled due to failing status checks.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Read more information about the use of Renovate Bot within Laminas.