search

laminas / laminas-stratigility

PSR-7 middleware foundation for building and dispatching middleware pipelines
https://docs.laminas.dev/laminas-stratigility/
BSD 3-Clause "New" or "Revised" License
55 stars 12 forks source link

Update dependency laminas/laminas-diactoros to ^2.24.2 [SECURITY] #41

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
laminas/laminas-diactoros (source) require-dev patch ^2.22 -> ^2.24.2

GitHub Vulnerability Alerts

CVE-2023-29530

Impact

Affected versions of Laminas Diactoros accepted a single line feed (LF / \n ) character at the end of a header name. When serializing such a header name containing a line-feed into the on-the-wire representation of a HTTP/1.x message, the resulting message would be syntactically invalid, due to the header line being terminated too early. An attacker that is able to control the header names that are passed to Laminas Diactoros would be able to intentionally craft invalid messages, possibly causing application errors or invalid HTTP requests being sent out with an PSR-18 HTTP client. The latter might present a denial of service vector if a remote service’s web application firewall bans the application due to the receipt of malformed requests.

Patches

The problem has been patched in the following versions:

Workarounds

Validate HTTP header keys and/or values, and if using user-supplied values, filter them to strip off leading or trailing newline characters before calling withHeader().

References

Release Notes

laminas/laminas-diactoros ### [`v2.24.2`](https://togithub.com/laminas/laminas-diactoros/compare/2.24.1...2.24.2) [Compare Source](https://togithub.com/laminas/laminas-diactoros/compare/2.24.1...2.24.2) ### [`v2.24.1`](https://togithub.com/laminas/laminas-diactoros/releases/tag/2.24.1) [Compare Source](https://togithub.com/laminas/laminas-diactoros/compare/2.24.0...2.24.1) ##### Release Notes for [2.24.1](https://togithub.com/laminas/laminas-diactoros/milestone/52) 2.24.x bugfix release (patch) ##### 2.24.1 - Total issues resolved: **0** - Total pull requests resolved: **1** - Total contributors: **1** ##### Bug - [135: Examine `X-Forwarded-Host` for additional port information](https://togithub.com/laminas/laminas-diactoros/pull/135) thanks to [@​boesing](https://togithub.com/boesing)

Configuration

📅 Schedule: Branch creation - "" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

Read more information about the use of Renovate Bot within Laminas.

Xerkus commented 1 year ago

Renovate is not very good at security updates, huh? This would allow installation of next minor that got security patch release too.

boesing commented 1 year ago

Renovate is not very good at security updates, huh? This would allow installation of next minor that got security patch release too.

TBH: I do not see why we have to bump requirements in libraries in the first place. Nothing prevents the user from yet updating to one of the fixed versions by the constraints provided by this component. So projects are able to bump their dependencies. Especially for dev-dependencies I do not see any update at all and would let that be handled by one of the composer.lock maintenance PRs...

weierophinney commented 1 year ago

Resolved already with another patch; current 3.10.x branch is using 2.25 as the minimum.