Return PHP_INT_MAX when a file size would exceed 2GB on a 32-bit system

laminas / laminas-validator

Validation classes for a wide range of domains, and the ability to chain validators to create complex validation criteria

https://docs.laminas.dev/laminas-validator/

BSD 3-Clause "New" or "Revised" License

126 stars 55 forks source link

Closed gsteel closed 2 months ago

gsteel commented 2 months ago

Q	A
Bugfix	yes
RFC	yes

Closes #13

File sizes > 2GB will return weird values on 32-bit systems as described by #13

Should we consider this an issue at all?

If so, this patch will yield PHP_INT_MAX where it matters for file based validators.

Ocramius commented 2 months ago

Are 32-bit systems still that relevant? :thinking:

gsteel commented 2 months ago

Are 32-bit systems still that relevant? 🤔

I didn't think so either, and #13 is pretty old - Happy for this to all go into the wont-fix pile

boesing commented 2 months ago

7yo, I'd close it for now until there is a new report