search

laminas / laminas-view

Flexible view layer supporting and providing multiple view layers, helpers, and more
https://docs.laminas.dev/laminas-view/
BSD 3-Clause "New" or "Revised" License
74 stars 45 forks source link

Remove stream wrapper functionality #28

Closed weierophinney closed 2 years ago

weierophinney commented 4 years ago

Fixes #23.

Originally posted by @mtymek at https://github.com/zendframework/zend-view/pull/34

weierophinney commented 4 years ago

Tests are failing, but it looks like compatibility issues with other ServiceManager v3.

Originally posted by @mtymek at https://github.com/zendframework/zend-view/pull/34#issuecomment-181566972

weierophinney commented 4 years ago

As I said on #23, Since PHP 5.4.0, <?= is always available. Is this BC break ? ( situation when user uses extending \Zend\View\Stream ?)

Originally posted by @sasezaki at https://github.com/zendframework/zend-view/pull/34#issuecomment-279163160

weierophinney commented 4 years ago

@sasezaki the reason this is labeled as BC break is removal of API (even if protected). The correct approach could be deprecation + removal of these method bodies, while the API survives till the next major release.

Originally posted by @Ocramius at https://github.com/zendframework/zend-view/pull/34#issuecomment-279311863

weierophinney commented 4 years ago

@Ocramius thanks describe reason

Originally posted by @sasezaki at https://github.com/zendframework/zend-view/pull/34#issuecomment-279371719

weierophinney commented 4 years ago

@sasezaki it's an API change, which means that any subclasses may be broken by the change (that's why we use private by default now)

Originally posted by @Ocramius at https://github.com/zendframework/zend-view/pull/34#issuecomment-279468030