search

laminas / laminas-view

Flexible view layer supporting and providing multiple view layers, helpers, and more
https://docs.laminas.dev/laminas-view/
BSD 3-Clause "New" or "Revised" License
74 stars 45 forks source link

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #3

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

When using HTTPS with a port other than 443, the self links returned remain HTTP.

Please see: https://github.com/zendframework/zend-view/blob/master/src/Helper/ServerUrl.php#L149

There are plenty of use cases where people will use ports other than 443 for their HTTPS needs. I believe this needs to be refactored to be less strict.

I'm happy to make the PR contribution, but I wanted to submit the issue first to make sure this doesn't break some standard.

Originally posted by @jbh at https://github.com/zendframework/zend-view/issues/194

weierophinney commented 4 years ago

:+1: for a PR for this!

Originally posted by @weierophinney at https://github.com/zendframework/zend-view/issues/194#issuecomment-537574100

weierophinney commented 4 years ago

Great. I'll work on doing that within the next two days. I have some other tasks in queue.

Originally posted by @jbh at https://github.com/zendframework/zend-view/issues/194#issuecomment-537575866