laminas / laminas-xml

Utility library for XML usage, best practices, and security in PHP
BSD 3-Clause "New" or "Revised" License
14 stars 7 forks source link

PHP 8.0 support #2

Closed boesing closed 3 years ago

boesing commented 3 years ago

Feature Request

Q A
New Feature yes

Summary

To be prepared for the december release of PHP 8.0, this repository has some additional TODOs to be tested against the new major version.

In order to make this repository compatible, one has to follow these steps:

xvilo commented 3 years ago

@boesing I'm not sure if it's the right way or if it is already wanted, but created a small PR fixing at least 1 PHP 8.0 issue :) https://github.com/laminas/laminas-xml/pull/3/files

As an extra note I did not find any immediate issues with phpunit:

$ php -v
PHP 8.0.0RC3 (cli) (built: Oct 31 2020 17:06:24) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.0RC3, Copyright (c), by Zend Technologies

$ php composer.phar --version
Composer version 2.0.7 2020-11-13 17:31:06

$ php composer.phar test
> phpunit --colors=always
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

.................R.......                                         25 / 25 (100%)

Time: 175 ms, Memory: 4.00 MB

There was 1 risky test:

1) LaminasTest\Xml\SecurityTest::testScanForXXE
This test did not perform any assertions

/projects/laminas-xml/test/SecurityTest.php:36

OK, but incomplete, skipped, or risky tests!
Tests: 25, Assertions: 45, Risky: 1.