laminas / laminas-xml

Utility library for XML usage, best practices, and security in PHP
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

PHP 8.1 Support #7

Closed dakujem closed 2 years ago

dakujem commented 2 years ago

Hello. I stumbled upon being unable to run app with this package in PHP 8.1 environment.

This is what I get from Composer.

- laminas/laminas-xml[1.3.0, ..., 1.4.x-dev] require php ^7.3 || ~8.0.0 -> your php version (8.1.0) does not satisfy that requirement.

The issue is that the constraint in composer.json is as follows:

    "require": {
        "php": "^7.3 || ~8.0.0",
        "laminas/laminas-zendframework-bridge": "^1.0"
    },

(seen here)

I suggest changing "php": "^7.3 || ~8.0.0", to "php": "^7.3 || ^8.0", to support future versions of PHP.

laminas-bot commented 2 years ago

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee. If you have a security issue, please follow our security reporting guidelines. If you wish to take on the role of maintainer, please nominate yourself

tobias-trozowski commented 2 years ago

@dakujem see comment from froschdesign at https://github.com/laminas/laminas-xmlrpc/issues/18#issuecomment-981113218

dakujem commented 2 years ago

Thank you for your response. As I understand it, the support for PHP 8.1 is under development then.

FYI, I'm using the laminas/laminas-xml2json package that requires this one.

froschdesign commented 2 years ago

@dakujem

As I understand it, the support for PHP 8.1 is under development then.

Any help is welcome! 👍

dakujem commented 2 years ago

Sure, but the PR is already out :-) https://github.com/laminas/laminas-xml/pull/8

tobias-trozowski commented 2 years ago

@froschdesign not directly related to php 8.1 but as you ask me to do the same thing yesterday... does it makes sense to also remove the dependency on zendframework-bridge?

froschdesign commented 2 years ago

@tobias-trozowski As a separate pull request would be good, then we will have an extra entry in the release notes. Thanks in advance! 👍