Improve performance : count() and array_push removal when possible

laminas / laminas-zendframework-bridge

Alias legacy ZF class names to Laminas Project equivalents.

BSD 3-Clause "New" or "Revised" License

1.18k stars 21 forks source link

Improve performance : count() and array_push removal when possible #84

Closed samsonasik closed 3 years ago

samsonasik commented 3 years ago

Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com

Q	A
QA	yes

Description

Use empty [] comparison instead of count() for array when possible
Use array assign instead of array_push when possible

froschdesign commented 3 years ago

@samsonasik Why minor version?

samsonasik commented 3 years ago

@froschdesign its improvement, not bug fix, if i remember correctly, @Ocramius pointed for improve performance is targetting minor version.

froschdesign commented 3 years ago

@samsonasik All fine, but at the moment there is no visible benefit for the user. A benchmark would be perfect or at least a reference explaining why it is an improvement. I think the release notes should contain this type of information otherwise we will be asked again: "Why minor version?"