laminas / technical-steering-committee

Laminas Project Technical Steering Committee organization and processes.
BSD 3-Clause "New" or "Revised" License
39 stars 23 forks source link

[NOMINATION][MAINTAINER]: arhimede, alexmerlin, MarioRadu, for maintaining laminas-api-tools #135

Closed arhimede closed 2 days ago

arhimede commented 1 year ago

Nomination

I'm nominating the following people to maintain laminas-api-tools:

As the discussion started in this PR https://github.com/laminas/technical-steering-committee/pull/134 , I would like to nominate a group of developers from DotKernel Organization in order to refactor and/or maintain laminas-api-tools and other new or current API related libraries.

internalsystemerror commented 1 year ago

As discussed at the most recent TSC meeting (minutes not yet uploaded), the idea is a promising one and it was suggested that those nominated submit some PRs to the various laminas/mezzio repos. The intention with this is that it would:

After looking through the contribution history, I wasn't able to see anything outside of the dotkernel org, but if there are any could you mention this PR in those so we can track that here?

arhimede commented 1 year ago

@internalsystemerror @Ocramius

Do you have any kind of guidance where to start with PR's ?

There are any specific issues or repos that need now fixes, new features and similar ?

We need a starting point :-)

internalsystemerror commented 1 year ago

I know quite a few repos still need upgrading to psalm 5. We use renovate to bump dependencies, opening a PR if they don't upgrade cleanly, so you can look for PRs with the renovate label to see which upgrades needs some work still.

Here's a list of all open PRs across laminas for reference: https://github.com/pulls?q=is%3Aopen+is%3Apr+archived%3Afalse+user%3Alaminas+sort%3Acreated-asc+user%3Amezzio+user%3Alaminas-api-tools+

Also each organisation will have a list of projects: https://github.com/orgs/laminas/projects?query=is%3Aopen

alexmerlin commented 1 year ago

Hey guys! I'm Alex, one of the DotKernel developers recommended to you by @arhimede. Just wanted to warm up with something light so I tried to make my first PR on laminas/laminas-json-server to fix some issues reported by Psalm. I created my own branch and when I try to push my modifications, I get the following error:

remote: Permission to laminas/laminas-json-server.git denied to alexmerlin. fatal: unable to access 'https://github.com/laminas/laminas-json-server.git/': The requested URL returned error: 403

Should we be able to make PRs without being members of the Laminas Organization?

samsonasik commented 1 year ago

@alexmerlin you can read the contributing guideline at https://github.com/laminas/.github/blob/main/CONTRIBUTING.md#recommended-workflow-for-contributions

alexmerlin commented 1 year ago

Just made a new PR.

MarioRadu commented 1 year ago

Hello there! My name is Mario and I'm the other developer from DotKernel recommended by @arhimede. I've created a PR https://github.com/laminas/laminas-migration/pull/76 to fix some issues regarding Psalm checks.

arhimede commented 1 year ago

Me again .

My name is Julian, @arhimede , and i am from Dotkernel organisation.

I have created a PR https://github.com/laminas/laminas-paginator/pull/56 mostly to try the deployment process , also to fix Psalm checks.

arhimede commented 1 month ago

@alexmerlin @MarioRadu this issue is not actual anymore , since laminas api tools are in security-only mode. Let's open an separate issue for each of you , and do a separate PR in a repository that is marked as active, either in Mezzio or Components column from the status page https://getlaminas.org/packages-maintenance-status/