search

laminas / technical-steering-committee

Laminas Project Technical Steering Committee organization and processes.
BSD 3-Clause "New" or "Revised" License
39 stars 23 forks source link

Update agenda.md to include `Roave/BackwardCompatibilityCheck` in laminas builds #160

Closed Slamdunk closed 10 months ago

Slamdunk commented 10 months ago

I always assumed it was already part of the build, and I almost released an unwanted BC Break for that:

https://github.com/laminas/laminas-form/pull/248#pullrequestreview-1747650048

boesing commented 10 months ago

FYI: It is available if you enable the scan via configuration. Add backwardCompatibilityCheck with true via .laminas-ci.json file.

I wanted it to be opt-in to prevent having weird surprises in 3rd-party upstream. Since we already worked on a v2 of the container where old PHP versions were dropped as well, I thought having that flag being enabled by-default in v2 makes sense.

Maybe it makes sense to have the matrix action to assume it as true for all mezzio/*, laminas-api-tools/* and lamians/* projects by default.

I've also created 3 issues regarding the backwards compatibility feature in the CI matrix: https://github.com/laminas/laminas-ci-matrix-action/issues/288 https://github.com/laminas/laminas-ci-matrix-action/issues/287 https://github.com/laminas/laminas-ci-matrix-action/issues/286