search

laminlabs / cellxgene-lamin

Access the cellxgene data using LaminDB.
https://docs.lamin.ai/cellxgene
Apache License 2.0
5 stars 0 forks source link

Fix curate throwing an exception on instantiation #72

Closed Zethson closed 3 months ago

Zethson commented 3 months ago

Fixes https://github.com/laminlabs/cellxgene-lamin/issues/69

Zethson commented 3 months ago

Waiting for CI to be fixed and then I'll continue.

falexwolf commented 3 months ago

:D

github-actions[bot] commented 3 months ago

🚀 Deployed on https://66a9f1418ec79c852390f92d--cellxgene-census-lamin-c192.netlify.app

falexwolf commented 3 months ago

This is great!

Just one small thing.

We've historically used bt.settings.organism to build bad solutions, and so @sunnyosun & I agreed to eliminate it everywhere in the docs.

If a user wants it, they can still use it, but it's nothing we advocate so that also users write code that's locally scoped.

Can you please rewrite this without using the global setting? I hope it's just 2 lines to change. If it's more effort, then there might be a scoping problem.

image
Zethson commented 3 months ago

Ahh I was wondering about that. Sure, should be easy!

falexwolf commented 3 months ago

Thanks, Lukas!