search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 2 forks source link

🐛 Fix permission error for init of hosted instances #636

Closed Koncopd closed 9 months ago

Koncopd commented 9 months ago

This fixes the permission error and also circumvents the need for CreateBucket permission for Locker.

Koncopd commented 9 months ago

This has problem with set.storage, i will debug later.

falexwolf commented 9 months ago

Thanks a ton for this, Sergei!

github-actions[bot] commented 9 months ago

🚀 Deployed on https://65bd01f5d1a24696e1301263--lamindb-setup-htry.netlify.app

Koncopd commented 9 months ago

@falexwolf the only problem left i believe is linting in build / prod-only

falexwolf commented 9 months ago

Ok, I'll fix linting!

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4b64249) 83.09% compared to head (cca9cc3) 83.46%. Report is 3 commits behind head on main.

Files Patch % Lines
lamindb_setup/_check_instance_setup.py 0.00% 1 Missing :warning:
lamindb_setup/dev/cloud_sqlite_locker.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #636 +/- ## ========================================== + Coverage 83.09% 83.46% +0.37% ========================================== Files 36 36 Lines 2194 2196 +2 ========================================== + Hits 1823 1833 +10 + Misses 371 363 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.