search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 1 forks source link

🐛 Fix directory uploads for hosted instances #702

Closed Koncopd closed 4 months ago

Koncopd commented 4 months ago

trying to fix https://github.com/laminlabs/lamindb-setup/issues/697

github-actions[bot] commented 4 months ago

🚀 Deployed on https://660e90f15e40e200a13dca3d--lamindb-setup-htry.netlify.app

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.77%. Comparing base (247eb2a) to head (dd63402).

Files Patch % Lines
lamindb_setup/core/upath.py 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #702 +/- ## ========================================== + Coverage 82.71% 82.77% +0.05% ========================================== Files 39 39 Lines 2476 2490 +14 ========================================== + Hits 2048 2061 +13 - Misses 428 429 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

falexwolf commented 4 months ago

How are things going here, @Koncopd? Will this be working at some point today?

Koncopd commented 4 months ago

In progress. Yes, it will be finished today.

falexwolf commented 4 months ago

Why do we need to call recursive=True for this simple test example? What does it do if we don't pass recursive? I thought it'd upload the first level?

image
Koncopd commented 4 months ago

It won't expand left paths. The simple rule is to always set recursive=True when you upload directories.