search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 1 forks source link

Can't import lamindb-setup on python 3.9 #710

Closed Koncopd closed 4 months ago

Koncopd commented 4 months ago

due to https://github.com/laminlabs/lamindb-setup/blob/01b1a6864d98672127606fd746c72e841d84a32e/lamindb_setup/core/types.py#L7

Koncopd commented 4 months ago

@falexwolf why not just use typing.Union here?

falexwolf commented 4 months ago

Yes, that's how I fixed it in my current PR - I want the new annotations for aesthetics reasons. The docs are way too ugly otherwise.

But for a TypeAlias, if Sphinx is properly configured, we'd not see Union, I think.

falexwolf commented 4 months ago

But in fact it might also not work at all: https://laminlabs.slack.com/archives/C04A0RMA0SC/p1712218806650409?thread_ts=1712086065.426689&cid=C04A0RMA0SC

falexwolf commented 4 months ago

I'm running docs building within lamindb on Python 3.8 now. This should avoid this from happening again.