search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 1 forks source link

🚸 In `.delete()`, check for data deletion & delete from hub #725

Closed falexwolf closed 4 months ago

falexwolf commented 4 months ago

Deletes instances on the hub and adds an additional check.

This still doesn't delete remote postgres instances.

github-actions[bot] commented 4 months ago

🚀 Deployed on https://6626b07e36d4cb1e8f99cdcf--lamindb-setup-htry.netlify.app

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (c2c20d4) to head (e843698).

Files Patch % Lines
lamindb_setup/_connect_instance.py 83.33% 1 Missing :warning:
lamindb_setup/_delete.py 97.22% 1 Missing :warning:
lamindb_setup/core/upath.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #725 +/- ## ========================================== + Coverage 81.35% 81.74% +0.38% ========================================== Files 39 39 Lines 2483 2525 +42 ========================================== + Hits 2020 2064 +44 + Misses 463 461 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.