Closed falexwolf closed 4 months ago
Attention: Patch coverage is 93.87755%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 80.76%. Comparing base (
af6100e
) to head (2d73141
). Report is 1 commits behind head on main.:exclamation: Current head 2d73141 differs from pull request most recent head 9465a2d. Consider uploading reports for the commit 9465a2d to get more accurate results
Files | Patch % | Lines |
---|---|---|
lamindb_setup/_migrate.py | 33.33% | 2 Missing :warning: |
lamindb_setup/core/django.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I guess local instances also should have local storage, but it should be the same as root. Right?
I guess local instances also should have local storage, but it should be the same as root. Right?
Yes! The naming choice is slightly confusing for local instances, but simpler than saying "hybrid" for cloud instances.
The point is to make it easy for users to keep their data local also when working with cloud instances.
They'll have a switch on the hub called "Keep data local" or "Default to local storage" or similar.
I'm pretty sure we'll not allow to have purely local instances on the hub going forward.
It is not actually clear than what is the difference between local and cloud now. Because a local instance can change its root to cloud but the local storage stays the same i guess. So now every instance can have cloud storage and local storage. So there is not much difference i suppose.
It is not actually clear than what is the difference between local and cloud now. Because a local instance can change its root to cloud but the local storage stays the same i guess. So now every instance can have cloud storage and local storage. So there is not much difference i suppose.
You are correct. I'm simply trying to achieve a more convenient UX for users who want to default to local storage working on a common server. I'll give this yet another refactor because the UX is still confusing.
https://www.notion.so/laminlabs/Data-sharing-through-hybrid-local-remote-LaminDB-instances-e01025ed0e3e4f06948c4390894f20a8
Replace the initial draft:
Needs: