search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 2 forks source link

🐛 Fix Supabase auth thread that prevents exit #800

Closed fredericenard closed 1 month ago

fredericenard commented 1 month ago

Here are related Supabase issues:

I'm not entirely sure removing sign out makes sense everywhere, fell free to put it back if needed.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://669fe09a209146009e4b6f7b--lamindb-setup-htry.netlify.app

Koncopd commented 1 month ago

Interesting, is it the reason our CI frequently hangs?

Koncopd commented 1 month ago

Reading the pinned threads, it looks to me that sign out should be left in the code and actually probably added at some other places. Thank you very much for finding the root of the problem.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (c53417e) to head (bf23fe2).

Files Patch % Lines
lamindb_setup/core/_hub_client.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #800 +/- ## ========================================== + Coverage 82.06% 82.16% +0.09% ========================================== Files 42 42 Lines 3134 3123 -11 ========================================== - Hits 2572 2566 -6 + Misses 562 557 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.