search

laminlabs / lamindb-setup

Setup & configure LaminDB.
Apache License 2.0
4 stars 2 forks source link

🐛 Do not delete existing storage records in hub on failed inits #821

Closed Koncopd closed 4 weeks ago

Koncopd commented 4 weeks ago

https://laminlabs.slack.com/archives/C07DB677JF6/p1723656079519069?thread_ts=1723618378.437019&cid=C07DB677JF6

github-actions[bot] commented 4 weeks ago

🚀 Deployed on https://66bcf9ee4adcc402a87bdf0a--lamindb-setup-htry.netlify.app

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (a3c5ca7) to head (a3a37bd). Report is 1 commits behind head on main.

Files Patch % Lines
lamindb_setup/core/_hub_core.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #821 +/- ## ========================================== - Coverage 83.45% 83.14% -0.31% ========================================== Files 42 42 Lines 3233 3234 +1 ========================================== - Hits 2698 2689 -9 - Misses 535 545 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

falexwolf commented 4 weeks ago

Interesting, I think this is correct. Man, it'd be nice to have a test for these situations, but well.

Koncopd commented 4 weeks ago

I agree, but these things are kind of hard to test properly.