Closed falexwolf closed 5 days ago
@sunnyosun convinced me that we should have a dedicated spot for this syncing information, and the hub already expects this.
In most cases, one could simplify the above query to:
ln.Run.get(reference="cheesy_engelbart")
So, I guess it's all good.
UX-wise, querying via
params
seems better than querying via
reference
andreference_type
Currently, the information is duplicated and stored both in the parameter dictionary and the two simple fields: https://docs.lamin.ai/nextflow. Of course, that's bad/confusing.
On the hub, the
nextflow_id
appears to be another param, but in fact it isn't:The
Run
interface isn't so terrible, but if we can ditchreference
andreference_type
then it'd be even simpler and the user could spend all their energy to learnparams
rather than learningreference
/reference_type
+params
.https://docs.lamin.ai/lamindb.track never supported
reference
andreference_type
in the first place.The crux with
reference
andreference_type
is that often you have multiple references that you'd like to sync something with, e.g.nextflow_run_id
,benchling_run_id
, etc. -- and then one walks away confused. Withparams
, that'd be very easy to deal with because we have key-value pairs in the first place.What are the arguments against this?
reference
might be distinct enough from a "run parameter" to not be considered a parameter.reference
field is more performant than querying the JSON field.WDYT @Zethson @sunnyosun?
We have
reference
andreference_type
also onULabel
andCollection
; both of which is problematic, too, but another discussion and doesn't need to be impacted by the discussion here.