search

laminlabs / lamindb

A data framework for biology.
https://docs.lamin.ai
Apache License 2.0
129 stars 12 forks source link

✨ Add `Collection.append()` #2077

Closed Koncopd closed 1 month ago

Koncopd commented 1 month ago

This is how it looks on https://docs.lamin.ai/lamindb.collection:

image
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.61%. Comparing base (80fb3b0) to head (ef420ad). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2077 +/- ## ========================================== + Coverage 92.39% 92.61% +0.21% ========================================== Files 54 54 Lines 6341 6431 +90 ========================================== + Hits 5859 5956 +97 + Misses 482 475 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://671283473dd60063353fab48--lamindb-qnwk.netlify.app

falexwolf commented 1 month ago

@Koncopd, you gotta point the submodule to the main branch before merging. The main lamindb branch still points to your closed lnschema-core PR.

falexwolf commented 1 month ago

I will fix this in my PR.

falexwolf commented 1 month ago

Ok, now I see you fixed it...

https://github.com/laminlabs/lamindb/commit/92c041f43dd63001fe8a072ba35e502782b72b6f

falexwolf commented 1 month ago

Which breaks things entirely:

image
falexwolf commented 1 month ago

Let me fix this. I don't where lnschema-core is now on main...

falexwolf commented 1 month ago

This is messy:

image

I'll force push to clean this up.

falexwolf commented 1 month ago

@Koncopd, can you please comprehensively document your PRs with "before" and "after", rationales, cross-linked related PRs etc.?