Closed Zethson closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.53%. Comparing base (
c41fc2c
) to head (b35200e
). Report is 12 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.
The problem with ablog
is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11
pinging @falexwolf
The latest version of ablog
doesn't use pkg_resources
.
We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.
I think 3.9 as a lower bound and 3.12 as the upperbound is fine. We can of course have a bigger matrix but I think it's okay. I think that it's very important that we test 3.12 in the CI.
The problem with ablog is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11 pinging @falexwolf The latest version of ablog doesn't use pkg_resources.
I think 3.9 as a lower bound and 3.12 as the upperbound is fine.
Agree, you are right.
Merging this now because we still build the docs with 3.10. We can upgrade the docs job later.
Docs don't build with 3.12:
See https://github.com/laminlabs/lndocs/issues/105