laminlabs / lamindb

A data framework for biology.
https://docs.lamin.ai
Apache License 2.0
129 stars 12 forks source link

✨ Python 3.12 support #2092

Closed Zethson closed 4 weeks ago

Zethson commented 1 month ago

Docs don't build with 3.12:

Extension error:
Could not import extension ablog (exception: No module named 'pkg_resources')

See https://github.com/laminlabs/lndocs/issues/105

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.53%. Comparing base (c41fc2c) to head (b35200e). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2092 +/- ## ======================================= Coverage 92.52% 92.53% ======================================= Files 54 54 Lines 6435 6429 -6 ======================================= - Hits 5954 5949 -5 + Misses 481 480 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://671771104fb3299af2c232dd--lamindb-qnwk.netlify.app

Koncopd commented 1 month ago

We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.

Koncopd commented 1 month ago

The problem with ablog is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11 pinging @falexwolf The latest version of ablog doesn't use pkg_resources.

Zethson commented 1 month ago

We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.

I think 3.9 as a lower bound and 3.12 as the upperbound is fine. We can of course have a bigger matrix but I think it's okay. I think that it's very important that we test 3.12 in the CI.

The problem with ablog is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11 pinging @falexwolf The latest version of ablog doesn't use pkg_resources.

See https://github.com/laminlabs/lndocs/issues/105

Koncopd commented 1 month ago

I think 3.9 as a lower bound and 3.12 as the upperbound is fine.

Agree, you are right.

Zethson commented 4 weeks ago

Merging this now because we still build the docs with 3.10. We can upgrade the docs job later.